Regression tests: Ensure __LINE__ is expanded#4557
Merged
tautschnig merged 1 commit intodiffblue:developfrom Apr 24, 2019
Merged
Regression tests: Ensure __LINE__ is expanded#4557tautschnig merged 1 commit intodiffblue:developfrom
tautschnig merged 1 commit intodiffblue:developfrom
Conversation
We previously generated several declarations with the same name, because the C preprocessor does not expand __LINE__ after a concatenation operator. Add two levels of indirection to achieve this. Using declarations with the same name was kind of ok for the C front-end, but is a bug with any C++ front-end.
4 tasks
allredj
reviewed
Apr 19, 2019
Contributor
allredj
left a comment
There was a problem hiding this comment.
This PR failed Diffblue compatibility checks (cbmc commit: 949b116).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/108999105
Status will be re-evaluated on next push.
Common spurious failures include: the cbmc commit has disappeared in the mean time (e.g. in a force-push); the author is not in the list of contributors (e.g. first-time contributors); compatibility was already broken by an earlier merge.
smowton
approved these changes
Apr 24, 2019
tautschnig
added a commit
that referenced
this pull request
Apr 24, 2019
Regression tests: Ensure __LINE__ is expanded
Collaborator
|
We could contemplate |
Collaborator
Author
Hmm, yes, but then we'd also have to add -std=c11 to all the goto-cc invocations? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We previously generated several declarations with the same name, because
the C preprocessor does not expand LINE after a concatenation
operator. Add two levels of indirection to achieve this. Using
declarations with the same name was kind of ok for the C front-end, but
is a bug with any C++ front-end.
This is in preparation of running a subset of the C test against the C++ front-end.