Rename lambda_exprt to array_comprehension_exprt#4683
Merged
tautschnig merged 2 commits intodiffblue:developfrom May 22, 2019
Merged
Rename lambda_exprt to array_comprehension_exprt#4683tautschnig merged 2 commits intodiffblue:developfrom
tautschnig merged 2 commits intodiffblue:developfrom
Conversation
This kind of exprt does not represent lambda functions, but it represents an array by specifying a range and a function operating on the array indices. This is a type of list/array comprehension, so calling it array_comprehension_exprt is more descriptive of what this type is used for.
antlechner
requested review from
kroening,
martin-cs,
peterschrammel and
pkesseli
as code owners
thomasspriggs
approved these changes
May 21, 2019
Contributor
thomasspriggs
left a comment
thomasspriggs
left a comment
There was a problem hiding this comment.
Makes sense to me. 👍
tautschnig
approved these changes
May 22, 2019
Collaborator
tautschnig
left a comment
tautschnig
left a comment
There was a problem hiding this comment.
Thank you for cleaning this up!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in a comment on #4672, this is a suggestion to rename the newly introduced type
lambda_exprttoarray_comprehension_exprt, which I find more intuitive. Some more documentation is also added.If there is a good reason to keep the old name, or if another name would be more suitable, let me know and I'll change the first commit accordingly.