Replace definition of value_sett::object_map_dt #4694
Merged
romainbrenguier merged 2 commits intodiffblue:developfrom May 23, 2019
Merged
Replace definition of value_sett::object_map_dt #4694romainbrenguier merged 2 commits intodiffblue:developfrom
romainbrenguier merged 2 commits intodiffblue:developfrom
Conversation
5 tasks
smowton
approved these changes
May 22, 2019
Contributor
smowton
left a comment
There was a problem hiding this comment.
s/blank/empty, otherwise lgtm
tautschnig
approved these changes
May 22, 2019
Collaborator
tautschnig
left a comment
There was a problem hiding this comment.
clang-format isn't happy and +1 on using empty_object_map instead of blank_object_map, otherwise looks good, another nice piece of cleanup!
This is so that the class can be used by types that do not have a static `blank` field. A particular case which would be useful in our codebase is std::map.
Instead of defining a new class with the same interface as std::map and which use std::map internally, we use using and define outside the static field `blank` which is the only thing added to std::map. This simplifies a lot the code in the value_set class header.
490457c to
fdfca41
Compare
romainbrenguier
added a commit
to romainbrenguier/cbmc
that referenced
this pull request
May 24, 2019
This was removed recently in pull request diffblue#4694 but it seems necessary when compiling with clang which would complain about it not being defined.
4 tasks
romainbrenguier
added a commit
to romainbrenguier/cbmc
that referenced
this pull request
May 24, 2019
The explicit definition of object_mapt equality was removed recently in pull request diffblue#4694 but it seems necessary when compiling with clang which would complain about it not being defined.
romainbrenguier
added a commit
to romainbrenguier/cbmc
that referenced
this pull request
May 24, 2019
The explicit definition of object_mapt equality was removed recently in pull request diffblue#4694 but it seems necessary when compiling with clang which would complain about it not being defined. Should fix diffblue#4699
romainbrenguier
added a commit
to romainbrenguier/cbmc
that referenced
this pull request
May 24, 2019
The explicit definition of object_mapt equality was removed recently in pull request diffblue#4694 but it seems necessary when compiling with clang which would complain about it not being defined. Should fix diffblue#4699
romainbrenguier
added a commit
to romainbrenguier/cbmc
that referenced
this pull request
May 24, 2019
The explicit definition of object_mapt equality was removed recently in pull request diffblue#4694 but it seems necessary when compiling with clang which would complain about it not being defined. Should fix diffblue#4699
romainbrenguier
added a commit
to romainbrenguier/cbmc
that referenced
this pull request
May 24, 2019
The explicit definition of object_mapt equality was removed recently in pull request diffblue#4694 but it seems necessary when compiling with clang which would complain about it not being defined. Should fix diffblue#4699
romainbrenguier
added a commit
to romainbrenguier/cbmc
that referenced
this pull request
May 28, 2019
The explicit definition of object_mapt equality was removed recently in pull request diffblue#4694 but it seems necessary when compiling with clang which would complain about it not being defined. Should fix diffblue#4699
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of defining a new class with the same interface as std::map and
which use std::map internally, we use using and define outside the
static field
blankwhich is the only thing added to std::map.