Conversation
kroening
commented
May 28, 2019
kroening
commented
- Each commit message has a non-empty body, explaining why the change was made.
- Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
- n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
- Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
- n/a My commit message includes data points confirming performance improvements (if claimed).
- My PR is restricted to a single feature or bugfix.
- n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.
kroening
requested review from
peterschrammel,
pkesseli and
smowton
as code owners
kroening
force-pushed
the
make_boolean_expr
branch
from
9b236c1 to
730928c
Compare
tautschnig
left a comment
tautschnig
left a comment
There was a problem hiding this comment.
Modulo the comments posted moments ago.
kroening
force-pushed
the
make_boolean_expr
branch
2 times, most recently
from
3052d26 to
ba40a39
Compare
allredj
left a comment
allredj
left a comment
There was a problem hiding this comment.
This PR failed Diffblue compatibility checks (cbmc commit: 9b236c1).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/113455813
Status will be re-evaluated on next push.
Common spurious failures include: the cbmc commit has disappeared in the mean time (e.g. in a force-push); the author is not in the list of contributors (e.g. first-time contributors); compatibility was already broken by an earlier merge.
allredj
left a comment
allredj
left a comment
There was a problem hiding this comment.
This PR failed Diffblue compatibility checks (cbmc commit: 730928c).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/113461406
Status will be re-evaluated on next push.
Common spurious failures include: the cbmc commit has disappeared in the mean time (e.g. in a force-push); the author is not in the list of contributors (e.g. first-time contributors); compatibility was already broken by an earlier merge.
kroening
force-pushed
the
make_boolean_expr
branch
from
ba40a39 to
acf02ac
Compare
This is a type-safe drop-in replacement for exprt::make_bool(value).
This ensures type safety.
This method isn't type safe, and make_boolean_expr(value) is an easy-to-use replacement.
kroening
force-pushed
the
make_boolean_expr
branch
from
acf02ac to
e60d6e9
Compare
allredj
left a comment
allredj
left a comment
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: e60d6e9).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/113731033
4 participants
