Clean Const Function Pointer Removal#519

Merged

kroening merged 46 commits intodiffblue:masterfrom

thk123:feature/clean-fp-removal

Apr 4, 2017

Commits on Mar 24, 2017

Adding tests for function pointer removal
thk123
committed
Made remove_function_pointers inherit from messaget
thk123
committed
First implemention of the new approach
thk123
committed
Support for removing the typecast
thk123
committed
Adding support for top level pointers and typecasts
thk123
committed
Fixing arrays containing null pointers
thk123
committed
Correctly deal with const structures
thk123
committed
Fixing component access and const access
thk123
committed
Fixing todo to use separate array
thk123
committed
Corrected const-ness for components
thk123
committed
Handle failure to squash the value when getting out of an array
thk123
committed
Correcting const check for pointers
thk123
committed
Adding examples to tests of what the const prevents
thk123
committed
Corrected const check for no FP pointers
thk123
committed
Added tests to cover a couple of missed lines
thk123
committed
Fixed issue with structs with other components
thk123
committed
Adding test for another way the previous bug could be exhibited
thk123
committed
Adding a test variation of 44 without the consts that fails correctly
thk123
committed
Squash constant symbols first
thk123
committed
Fixed major bug with non const structs
thk123
committed
Removing redundant code
thk123
committed
Added logging for all the ways the FP removal might not complete
thk123
committed
Adding consistency checks for the output
thk123
committed
Adding comments to remove_const_function_pointers
thk123
committed
Renamed all the tests
thk123
committed
Tidied up tests

thk123
authored and
thk123
committed
Fixing compile errors for musketeer

thk123
authored and
thk123
committed
Refactored resolve_index_of_function_call

thk123
authored and
thk123
committed
Split out functions from try_resolve_function_call

thk123
authored and
thk123
committed
Made the behaviour of try_resolve_function_call clearer

thk123
authored and
thk123
committed
Split up try_resolve_expression into functions

thk123
authored and
thk123
committed
Made other try_resolve*_function_call use the normal method

thk123
authored and
thk123
committed
Extracted element dealing with calling resolve on each result

thk123
authored and
thk123
committed
Adding the pointer check flag

thk123
authored and
thk123
committed
Adding checks for NULL function pointers

thk123
authored and
thk123
committed
Renaming functions to more consistent name

thk123
authored and
thk123
committed
Swap to using an unorded set

thk123
authored and
thk123
committed
Added flag for goto-instrument to just remove const function pointers

thk123
authored and
thk123
committed
Check the GOTO program for loss of const

thk123
authored and
thk123
committed
Added a couple of missed test cases.

thk123
authored and
thk123
committed
Fixing tests to work with new test.pl

thk123
authored and
thk123
committed
Fixing missing new lines

thk123
authored and
thk123
committed
Split out the const check into own analysis
thk123
committed
Descend all children of the same base type
thk123
committed
PR Feedback implementation
thk123
committed
Use pointers in is_type_at_least_as_const_as
thk123
committed