Closed
Conversation
(INT) Interval values
Also fix wrong placing of parentheses in output
As it stands in conflicted with the method from exprt
So they don't conflict with the exprt methods
Also, mark them as explicit where appropriate and add some documentation
Also replace some asserts with INVARIANT, PRECONDITION or UNREACHABLE
Also left some comments for things that need to be cleaned up in the future
Also, refactor minus and correct a typo in the comments
And also add tests for it.
and add tests for them and eval.
Previously the typecast operator for interval_exprt simply set the type on the bounds; This yielded incorrect results for widening or narrowing casts. This delegates the typecast handling to simplify_expr instead.
Contributor
Author
|
CI failing due to seemingly missing unit tests from the Makefile |
Codecov Report
@@ Coverage Diff @@
## develop #5354 +/- ##
========================================
Coverage 68.04% 68.04%
========================================
Files 1172 1172
Lines 97151 97151
========================================
Hits 66106 66106
Misses 31045 31045
Continue to review full report at Codecov.
|
Contributor
Author
|
On this branch I've attempted to start tidying up the interface - but this work should wait until VSD is merged, to avoid having to dive into the VSD commits and fixing them inline |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased version of #5203 to see codecov report