Skip to content

De-duplicate version output code#6089

Merged
tautschnig merged 1 commit intodiffblue:developfrom
tautschnig:version-output-refactor
May 7, 2021
Merged

De-duplicate version output code#6089
tautschnig merged 1 commit intodiffblue:developfrom
tautschnig:version-output-refactor

Conversation

@tautschnig
Copy link
Copy Markdown
Collaborator

Several front-ends used the same piece of code (except for the
front-end's name) to print version information. Factor this out into a
method of parse_options_baset.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Several front-ends used the same piece of code (except for the
front-end's name) to print version information. Factor this out into a
method of parse_options_baset.
@tautschnig tautschnig force-pushed the version-output-refactor branch from ed261c9 to 3776bf2 Compare May 7, 2021 06:08
@tautschnig tautschnig marked this pull request as ready for review May 7, 2021 06:08
@codecov
Copy link
Copy Markdown

codecov bot commented May 7, 2021

Codecov Report

Merging #6089 (3776bf2) into develop (c29b69a) will increase coverage by 0.07%.
The diff coverage is 88.88%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6089      +/-   ##
===========================================
+ Coverage    74.44%   74.51%   +0.07%     
===========================================
  Files         1446     1447       +1     
  Lines       157778   157768      -10     
===========================================
+ Hits        117456   117568     +112     
+ Misses       40322    40200     -122     
Impacted Files Coverage Δ
jbmc/src/janalyzer/janalyzer_main.cpp 100.00% <ø> (ø)
jbmc/src/java_bytecode/assignments_from_json.cpp 97.26% <ø> (ø)
jbmc/src/java_bytecode/ci_lazy_methods.cpp 99.47% <ø> (ø)
jbmc/src/java_bytecode/ci_lazy_methods.h 100.00% <ø> (ø)
jbmc/src/java_bytecode/ci_lazy_methods_needed.cpp 98.24% <ø> (ø)
jbmc/src/java_bytecode/ci_lazy_methods_needed.h 100.00% <ø> (ø)
jbmc/src/java_bytecode/convert_java_nondet.cpp 81.15% <ø> (ø)
...java_bytecode/create_array_with_type_intrinsic.cpp 97.67% <ø> (ø)
jbmc/src/java_bytecode/expr2java.cpp 86.61% <ø> (ø)
jbmc/src/java_bytecode/expr2java.h 100.00% <ø> (ø)
... and 707 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ab5de1...3776bf2. Read the comment docs.

Copy link
Copy Markdown
Contributor

@chrisr-diffblue chrisr-diffblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much nicer :-)

@tautschnig tautschnig merged commit 247380f into diffblue:develop May 7, 2021
@tautschnig tautschnig deleted the version-output-refactor branch May 7, 2021 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants