Skip to content

Adds missing case to assigns clause type checking#6228

Closed
feliperodri wants to merge 3 commits intodiffblue:developfrom
feliperodri:fix-assigns-tc
Closed

Adds missing case to assigns clause type checking#6228
feliperodri wants to merge 3 commits intodiffblue:developfrom
feliperodri:fix-assigns-tc

Conversation

@feliperodri
Copy link
Copy Markdown
Collaborator

Signed-off-by: Felipe R. Monteiro felisous@amazon.com

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@feliperodri feliperodri added bugfix aws Bugs or features of importance to AWS CBMC users Code Contracts Function and loop contracts labels Jul 15, 2021
@feliperodri feliperodri self-assigned this Jul 15, 2021
@feliperodri feliperodri requested a review from SaswatPadhi July 15, 2021 18:46
@kroening
Copy link
Copy Markdown
Collaborator

BTW, convert_type is likely the wrong place to do the check. I'd move it to the typechecker.

Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
Copy link
Copy Markdown
Collaborator

@martin-cs martin-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to convert_type look good but I think the array changes should be handled separately.

Signed-off-by: Felipe R. Monteiro <felisous@amazon.com>
@feliperodri feliperodri marked this pull request as draft July 16, 2021 15:25
@feliperodri
Copy link
Copy Markdown
Collaborator Author

#6234 includes this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aws Bugs or features of importance to AWS CBMC users bugfix Code Contracts Function and loop contracts do not review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants