Merged
Conversation
Contributor
Author
|
@mgudemann You seem to have written quite a lot of the code in this file, so you might be a good person to review. On the other hand you seem to be on holiday next week. |
Member
There was a problem hiding this comment.
Was the renaming necessary then?
Contributor
Author
There was a problem hiding this comment.
No, I guess not. It was useful to be certain that the function was okay to remove. I'll add a commit to rename the remaining function back.
Collaborator
There was a problem hiding this comment.
You might just drop that earlier commit and rebase?
added 2 commits
March 24, 2017 15:02
skip_classid was always false, so there wasn't any point having it.
gen_nondet_init() is only used once, and is only two lines long, so get rid of it and just put those two lines. This also avoids confusion with java_object_factory::gen_nondet_init().
owen-mc-diffblue
force-pushed
the
cleanup/java-object-factory
branch
from
1c6676d to
9a1dae0
Compare
Contributor
Author
|
I've dropped the renaming commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been reading this code as we're making an equivalent for C. I noticed a few things that could be tidied up. There are no functional changes.