Add support for dynamic object sizes in old smt decision procedure#7768
Merged
thomasspriggs merged 4 commits intodiffblue:developfrom Jun 16, 2023
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #7768 +/- ##
===========================================
+ Coverage 77.59% 77.80% +0.21%
===========================================
Files 1693 1693
Lines 193309 193308 -1
===========================================
+ Hits 149997 150407 +410
+ Misses 43312 42901 -411
☔ View full report in Codecov by Sentry. |
The old SMT backend simply ignored the sizes of dynamically sized objects instead of actually defining the size. This allowed the solver to just choose whichever size it liked in order to reach an outcome of SAT, rather than applying any bounds which had been applied to the size. Actually translating the size where the expression is non-constant should fix various observable behaviors related to object sizes and bounds.
This is also fixed by support for dynamic object sizes.
thomasspriggs
force-pushed
the
tas/old_smt_dynamic_sizes
branch
from
fa13384 to
5da3a04
Compare
thomasspriggs
requested review from
NlightNFotis,
TGWDB,
kroening,
martin-cs and
peterschrammel
as code owners
7 tasks
TGWDB
approved these changes
Jun 16, 2023
NlightNFotis
approved these changes
Jun 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for dynamic object sizes in old SMT backend. This fixes #7690