Keep symbols as nondet rather than using their symbol table values in SMT decision procedure.#8104
Merged
thomasspriggs merged 1 commit intodiffblue:developfrom Dec 13, 2023
Conversation
4 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8104 +/- ##
===========================================
+ Coverage 79.07% 79.08% +0.01%
===========================================
Files 1698 1698
Lines 196464 196437 -27
===========================================
+ Hits 155347 155349 +2
+ Misses 41117 41088 -29 ☔ View full report in Codecov by Sentry. |
tautschnig
approved these changes
Dec 13, 2023
Collaborator
tautschnig
left a comment
There was a problem hiding this comment.
There now appear to be some includes that are no longer required.
Because the value of a symbol is not intended to be defined until it has been expressed via expressions explicitly passed to the decision procedure.
956afe4 to
c3a910f
Compare
TGWDB
approved these changes
Dec 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR keeps symbols as nondet rather than using their symbol table values in SMT decision procedure.
This is needed because the value of a symbol is not intended to be defined until it has been expressed via expressions explicitly passed to the decision procedure.
This should help with this PR - #7858