CSmith test script: avoid a need for argv modelling#8105
Merged
tautschnig merged 1 commit intodiffblue:developfrom Dec 14, 2023
Merged
CSmith test script: avoid a need for argv modelling#8105tautschnig merged 1 commit intodiffblue:developfrom
tautschnig merged 1 commit intodiffblue:developfrom
Conversation
With additional checks turned on as of diffblue#8093, we failed CSmith tests with (legitimate) pointer property failures in `strcmp`. These are caused by trying to compare `argv[1]` to a string. As we do not model `argv` in these tests, `argv[1]` was not a valid pointer. This fix just removes the string comparison, which is only used for turning on/off debug output in test execution.
4 tasks
TGWDB
approved these changes
Dec 14, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #8105 +/- ##
========================================
Coverage 79.08% 79.08%
========================================
Files 1698 1698
Lines 196465 196465
========================================
Hits 155380 155380
Misses 41085 41085 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With additional checks turned on as of #8093, we failed CSmith tests with (legitimate) pointer property failures in
strcmp. These are caused by trying to compareargv[1]to a string. As we do not modelargvin these tests,argv[1]was not a valid pointer. This fix just removes the string comparison, which is only used for turning on/off debug output in test execution.