Add support for a --no-unwinding-assertions flag#8109
Merged
esteffin merged 1 commit intodiffblue:developfrom Dec 16, 2023
Merged
Add support for a --no-unwinding-assertions flag#8109esteffin merged 1 commit intodiffblue:developfrom
--no-unwinding-assertions flag#8109esteffin merged 1 commit intodiffblue:developfrom
Conversation
NlightNFotis
requested review from
kroening,
peterschrammel,
tautschnig and
thomasspriggs
as code owners
Collaborator
|
Aren't we also missing the opposite for |
esteffin
force-pushed
the
no_unwinding_assertions
branch
2 times, most recently
from
d43d595 to
d737824
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #8109 +/- ##
===========================================
- Coverage 79.08% 79.08% -0.01%
===========================================
Files 1698 1698
Lines 196495 196502 +7
===========================================
+ Hits 155401 155405 +4
- Misses 41094 41097 +3 ☔ View full report in Codecov by Sentry. |
thomasspriggs
approved these changes
Dec 15, 2023
… option earlier to avoid bug
esteffin
force-pushed
the
no_unwinding_assertions
branch
from
d737824 to
93127fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for a
--no-unwinding-assertionsflag and move handling of option earlier to avoid bug in sequence-dependent printing code later on.This was part of the work needed for #8093 but we missed it and discovered it through testing earlier today.