Merged
Conversation
09727ab to
9299b4e
Compare
We only ever inherit from `c_qualifierst` and can safely avoid the use of `dynamic_cast` by making `expr2ct` use `c_qualifierst` instead of `qualifierst`. The `clone()` facility introduced in diffblue#1831 (where `qualifierst` was introduced) remains in place to support derived implementations (like `java_qualifierst`). Also, reduce the number of explicit `c_qualifierst()` calls by making use of `convert` and `convert_with_identifier`.
9299b4e to
eabcf9c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #8419 +/- ##
===========================================
+ Coverage 77.94% 77.95% +0.01%
===========================================
Files 1726 1726
Lines 189621 189591 -30
Branches 18247 18276 +29
===========================================
- Hits 147792 147791 -1
+ Misses 41829 41800 -29 ☔ View full report in Codecov by Sentry. |
kroening
approved these changes
Aug 20, 2024
TGWDB
approved these changes
Aug 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We only ever inherit from
c_qualifierstand can safely avoid the use ofdynamic_castby makingexpr2ctusec_qualifierstinstead ofqualifierst. Theclone()facility introduced in #1831 (wherequalifierstwas introduced) remains in place to support derived implementations (likejava_qualifierst).Also, reduce the number of explicit
c_qualifierst()calls by making use ofconvertandconvert_with_identifier.