Merged
Conversation
tautschnig
reviewed
May 12, 2017
src/util/ieee_float.cpp
Outdated
Collaborator
There was a problem hiding this comment.
Would it be possible to have a comment explaining the magic number -4?
Collaborator
Author
There was a problem hiding this comment.
I don't actually know where that is from (was there before); and actual implementations appear to be different.
Collaborator
There was a problem hiding this comment.
Would you mind adding a comment to that effect? In particular, the fact that actual implementations appear to differ sounds interesting to me.
src/util/ieee_float.cpp
Outdated
Collaborator
There was a problem hiding this comment.
I think I would have implemented this using result.find_last_not_of('0').
tautschnig
requested changes
May 15, 2017
Collaborator
tautschnig
left a comment
tautschnig
left a comment
There was a problem hiding this comment.
See earlier comments, but the main addition I'd ask for is a regression test covering this code, in particular the newly added e/E formatting.
tautschnig
approved these changes
May 16, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the output of floating-point numbers look more similar to what stdc libraries do