Rename convert to convert_with_precedence#935
Closed
owen-mc-diffblue wants to merge 1 commit intodiffblue:test-gen-supportfrom
Closed
Rename convert to convert_with_precedence#935owen-mc-diffblue wants to merge 1 commit intodiffblue:test-gen-supportfrom
owen-mc-diffblue wants to merge 1 commit intodiffblue:test-gen-supportfrom
Conversation
It is bad style to have an interface method the same name as an internal method with a different signature. Then on overriding one of these methods the compiler only finds the overloaded one with the wrong signature, doesn't look up the base class and fails. We fix this problem by renaming the protected method. This simplifies the code in all derived classes. # Conflicts: # src/java_bytecode/expr2java.h
owen-mc-diffblue
force-pushed
the
cleanup/using-expr2ct-convert-test-gen-support
branch
from
20b9438 to
b84a97d
Compare
Contributor
Author
|
This has been included in #941 . |
owen-mc-diffblue
deleted the
cleanup/using-expr2ct-convert-test-gen-support
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(This has already been merged to master in #916 and #937 .)
It is bad style to have an interface method the same name as an
internal method with a different signature. Then on overriding one of
these methods the compiler only finds the overloaded one with the wrong
signature, doesn't look up the base class and fails.
We fix this problem by renaming the protected method. This simplifies
the code in all derived classes.