Fix undefined instance var AS encryptor#31
Merged
marcqualie merged 3 commits intodiffcrypt:masterfrom Oct 6, 2020
swiknaba:fix-undefined-as-encryptor
Merged
Fix undefined instance var AS encryptor#31marcqualie merged 3 commits intodiffcrypt:masterfrom swiknaba:fix-undefined-as-encryptor
marcqualie merged 3 commits intodiffcrypt:masterfrom
swiknaba:fix-undefined-as-encryptor
Conversation
marcqualie
approved these changes
Oct 6, 2020
Collaborator
|
Related to: #29 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
creating new credentials fails with
it seems
decrypt_and_verifyis never called, thus@decrypt_and_verifyis not populated and hence results in this error.Not sure if
was intended to memorize the AS Message Encryptor instance, if so, we can drop in
@active_support_encryptor ||= ....