Sortpom should fail instead of silently sort on spotless:check

[tisonkun]

@Ekryd I'm trying to merge my sortpom config into spotless config build find that it doesn't failed on spotless:check but actually verifyFail == Sort.

I suppose we should use verifyFail == Stop so that it's the same manner as spotless.

Originally posted by @tisonkun in #2049 (comment)

[tisonkun]

@nedtwigg I'm not quite sure how check and format works (significant codepath).

I try to read the code but it's too dynamic to figure out. If you can describe the workflow perhaps I can try to work on a fix.

[Ekryd]

My experience with Spotless is very limited, so I will hand this over to the kind folks that maintain spotless. 🎈

[winniequinn]

@tisonkun: I'm not quite sure I understand, but, in at least in version 2.43.0 of Spotless and later, spotless:check does not modify the POM for me and spotless:apply does. You do not need to set verifyFail at all when using sortpom via Spotless.

If Spotless is formatting your POM via spotless:check, it might be helpful to post your full plugin configuration.