Reuse configs for GroovyExtension and GroovyGradleExtension#1892
Merged
nedtwigg merged 1 commit intodiffplug:mainfrom Nov 20, 2023
Merged
Reuse configs for GroovyExtension and GroovyGradleExtension#1892nedtwigg merged 1 commit intodiffplug:mainfrom
GroovyExtension and GroovyGradleExtension#1892nedtwigg merged 1 commit intodiffplug:mainfrom
Conversation
Goooler
commented
Nov 19, 2023
Comment on lines
-38
to
+29
| public class GroovyExtension extends FormatExtension implements HasBuiltinDelimiterForLicense, JvmLang { | ||
| public class GroovyExtension extends BaseGroovyExtension implements HasBuiltinDelimiterForLicense, JvmLang { |
Member
Author
There was a problem hiding this comment.
Should we implement HasBuiltinDelimiterForLicense for GroovyGradleExtension? If so we can move this into BaseGroovyExtension as well.
Member
There was a problem hiding this comment.
It's pretty hard to find the regex for Groovy, I think it's really hard to find it for GroovyGradle, as anything could be at the top. IMO hiding this regex from the user is counterproductive because too likely that they will end up needing to change something about it.
Goooler
changed the title
GroovyExtension and GroovyGradleExtension
Member
|
Nice refactor! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1890.