Skip to content

Remove the rome formatter#2119

Merged
nedtwigg merged 6 commits intomainfrom
feat/remove-rome
May 23, 2024
Merged

Remove the rome formatter#2119
nedtwigg merged 6 commits intomainfrom
feat/remove-rome

Conversation

@nedtwigg
Copy link
Copy Markdown
Member

Looks like Rome had a political rename to Biome. We had a ton of code all over the place pointing this out. Looks like there's more refactoring that could be done, but this seems like the essential stuff.

@blutorange anything else you'd like to add?

@blutorange
Copy link
Copy Markdown
Contributor

When I added support for biome after their transition from rome to biome, I changed at least the public API (i.e. the configuration in the pom.xml / gradle config). I left the Java classes unchanged to avoid any compatibility issues. But I suppose nobody actually includes this project as a dependency and builds against it, so it's probably ok to change it.

Also, at least until now, we did support the old rome tool (justifying why some classes should be named Rome*). Biome is now out for long enough a time that it might be fine if we removed support for rome, I think?

@nedtwigg nedtwigg enabled auto-merge May 23, 2024 19:53
@nedtwigg nedtwigg merged commit 2971c77 into main May 23, 2024
@nedtwigg nedtwigg deleted the feat/remove-rome branch May 23, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants