add `--is-test` to all test commands

[sbillinge]

90% of tests will pass without the --is-test flag set, but for consistency, I suggest we add this to all the tests. It will create less confusion in the future .

[stevenhua0320]

UC 1 Tester of LPP test the app runs successfully

1. Tester of app runs LPP and set --is-test to True
2. A tester uses particular test files to determine if corresponding functions run without errors or potential bugs.

[sbillinge]

UC 1 Tester of LPP test the app runs successfully

1. Tester of app runs LPP and set --is-test to True

2. A tester uses particular test files to determine if corresponding functions run without errors or potential bugs.

sorry, this is all very confusing. We don't need a UC for the tests. We are looking for pseudocode of the actual test functionality. Sorry it is so confusing. Thank you so much for your efforts to understand. I know it is confusing. UCs capture user behavior (no implementation information), pseudocode for hte test describe the actual code that will be written but not in real syntax.

[sbillinge]

Here is an example of pseudocode for the test.

def test_apply_correction():
    set current time to midnight 1st Jan 2024 using runfreeze
    actual = apply_correction(inputs, now)
    expected = get_args(set test bool)
    expected.creation_time = midnight 1st Jan 2024
    assert actual.creation_time = expected.creation_time

something like that.

[stevenhua0320]

OK, so for --is-test, since it is not for general users, here we directly consider its test function to consider its behavior right?

[sbillinge]

alternatively, since a goal is for that creation time to actually appear in the file, we could write a file and then check that the right time is in there.

On the whole, I think if we check that the right thing is loaded in args, and then later we make a test that checks that everything from args makes it into the file, this accomplishes the same thing

[sbillinge]

OK, so for --is-test, since it is not for general users, here we directly consider its test function to consider its behavior right?

I am afraid I don't understand your question. We may not need --is-test here actually if we use runfreeze.

[stevenhua0320]

Yes, that's what yucong and I previously thought about since for creation-time we may not use --is-test since we use freezegun to freeze time to test the datetime behavior. but for other cases, we might still use --is-test flags, so we might use it elsewhere.

[sbillinge]

Yes, that's what yucong and I previously thought about since for creation-time we may not use --is-test since we use freezegun to freeze time to test the datetime behavior. but for other cases, we might still use --is-test flags, so we might use it elsewhere.

in that case it is not needed in this PR at all.

[sbillinge]

Let's hold on this until we are sure it is needed. It is not something i want unless it is absolutely needed.

[sbillinge]

please review and close if need be

[yucongalicechen]

closed as no longer needed