Add GH actions for CI #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbillinge
reviewed
Feb 27, 2023
Contributor
sbillinge
left a comment
sbillinge
left a comment
There was a problem hiding this comment.
please see inline comments.
.github/workflows/main.yml
Outdated
| repository: diffpy/diffpy.pdfmorph | ||
| # for bookkeeping have diffpy.pdfmorph at the same level as everything else in the | ||
| # directory tree | ||
| path: diffpy.pdfmorph |
Contributor
There was a problem hiding this comment.
let's start as easy as possible, so change this to
path: .
.github/workflows/main.yml
Outdated
| # environment.yml file is needed by this action. Because I don't want | ||
| # maintain this but rather maintain the requirements files it just has | ||
| # basic things in it like conda and pip | ||
| environment-file: diffpy.pdfmorph/environment.yml |
Contributor
There was a problem hiding this comment.
then I think this would be ./environment.yml
.github/workflows/main.yml
Outdated
| shell: bash -l {0} | ||
| run: | | ||
| conda config --set always_yes yes --set changeps1 no | ||
| cd diffpy.pdfmorph |
Contributor
There was a problem hiding this comment.
delete this for now (cd diffpy.pdfmorph) but add
conda config --add channels conda-forge
| run: | | ||
| cd diffpy.pdfmorph/diffpy/pdfmorph | ||
| conda activate test | ||
| pytest tests |
Contributor
There was a problem hiding this comment.
we will need to insert here a line cd ./diffpy/pdfmorph before the pytest row.
requirements/run.txt
Outdated
| scipy | ||
| diffpy.utils | ||
| matplotlib | ||
| bg-mpl-stylesheets |
Contributor
There was a problem hiding this comment.
it might be better to do this on a different branch so we can merge it separately (and first)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #51