Skip to content

Conversation

@dabeycorn
Copy link
Member

No description provided.

dabeycorn added 4 commits July 5, 2025 20:04
Signed-off-by: Dasun Abeykoon <Dasun20202020@gmail.com>
…ense

Signed-off-by: Dasun Abeykoon <Dasun20202020@gmail.com>
Signed-off-by: Dasun Abeykoon <Dasun20202020@gmail.com>
Signed-off-by: Dasun Abeykoon <Dasun20202020@gmail.com>
@codecov
Copy link

codecov bot commented Jul 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.57%. Comparing base (055b0b2) to head (5e99353).
Report is 14 commits behind head on migration.

Additional details and impacted files
@@            Coverage Diff             @@
##           migration      #43   +/-   ##
==========================================
  Coverage      71.57%   71.57%           
==========================================
  Files              4        4           
  Lines            292      292           
==========================================
  Hits             209      209           
  Misses            83       83           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comments

dabeycorn added 6 commits July 7, 2025 10:39
Signed-off-by: Dasun Abeykoon <Dasun20202020@hotmail.com>
Signed-off-by: Dasun Abeykoon <Dasun20202020@hotmail.com>
Signed-off-by: Dasun Abeykoon <Dasun20202020@hotmail.com>
Signed-off-by: Dasun Abeykoon <Dasun20202020@hotmail.com>
Signed-off-by: Dasun Abeykoon <Dasun20202020@hotmail.com>
Signed-off-by: Dasun Abeykoon <Dasun20202020@hotmail.com>
@dabeycorn
Copy link
Member Author

@sbillinge ready for review

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see comment. Also, please replace doc/source/img/scikit-package-logo-text.png with an empty file called .placeholder

dabeycorn added 2 commits July 7, 2025 15:28
Signed-off-by: Dasun Abeykoon <Dasun20202020@hotmail.com>
@dabeycorn
Copy link
Member Author

dabeycorn commented Jul 7, 2025

@sbillinge ready for review (sorry, forgot to ask for one before)

@sbillinge sbillinge merged commit 2b3bfce into diffpy:migration Jul 8, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants