Skip to content

Conversation

@8bitsam
Copy link
Contributor

@8bitsam 8bitsam commented Jul 24, 2024

Fixed version of #45 - modifies files to more closely match the cookiecutter.

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, except I don't think examples should be in src as it is not part of the source code, it is rather part of the documentation, no?

We could maybe leave it as is (i.e., the examples stand alone at the top level in an examples dir), or we could slip it under doc so it is doc/examples.

On balance I think I prefer the latter solution.

@8bitsam
Copy link
Contributor Author

8bitsam commented Jul 25, 2024

This looks good, except I don't think examples should be in src as it is not part of the source code, it is rather part of the documentation, no?

We could maybe leave it as is (i.e., the examples stand alone at the top level in an examples dir), or we could slip it under doc so it is doc/examples.

On balance I think I prefer the latter solution.

I moved it into doc/.

@sbillinge sbillinge merged commit abe80bf into diffpy:cookie Jul 26, 2024
@8bitsam 8bitsam deleted the cookie-mod-files-v2 branch July 27, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants