Skip to content

Cookiecutting - multi-platform testing #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbillinge merged 6 commits into from
Jul 28, 2024
Merged

Cookiecutting - multi-platform testing #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
26b9e2e
multi-platform testing
8bitsam Jul 27, 2024
b97db66
test on multiple python versions
8bitsam Jul 27, 2024
5bf577b
update miniconda installation step
8bitsam Jul 27, 2024
40594b8
add specific version and conda to environment.yml
8bitsam Jul 27, 2024
b746b47
change environment.yml python version to range
8bitsam Jul 27, 2024
b4878cb
remove mac support
8bitsam Jul 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: ["ubuntu-latest"]
python-version: ['3.10', '3.11', '3.12']
os: ["ubuntu-latest", "windows-latest"]
Copy link
Contributor

@sbillinge sbillinge Jul 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we may need macos-latest to get it to test on the arm platforms?

steps:
- name: check out diffpy.pdffit2
uses: actions/checkout@v3
Expand All @@ -26,14 +27,15 @@ jobs:
- name: initialize miniconda
# this uses a marketplace action that sets up miniconda in a way that makes
# it easier to use. I tried setting it up without this and it was a pain
uses: conda-incubator/setup-miniconda@v2
uses: conda-incubator/setup-miniconda@v3
with:
miniconda-version: "latest"
activate-environment: test
# environment.yml file is needed by this action. Because I don't want
# maintain this but rather maintain the requirements files it just has
# basic things in it like conda and pip
environment-file: ./environment.yml
python-version: 3
python-version: ${{ matrix.python-version }}
auto-activate-base: false

- name: install diffpy.pdffit2 requirements
Expand Down
3 changes: 2 additions & 1 deletion environment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@ name: diffpy.pdffit2
channels:
- conda-forge
dependencies:
- python=3
- python>=3.10
- pip
- conda
- gsl
- gcc
- gxx