cookiecutter: modified files pt2 #154
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbillinge
reviewed
Aug 2, 2024
Contributor
sbillinge
left a comment
sbillinge
left a comment
There was a problem hiding this comment.
please see inline comments.
|
|
||
| control = PDFGuiControl() | ||
| control.load("../../tests/testdata/ni.ddp") | ||
| control.load("src/diffpy/pdfgui/tests/testdata/ni.ddp") |
Contributor
There was a problem hiding this comment.
did you test this? It is unlikely to work because this is a relative file-path.
| from importlib import resources | ||
|
|
||
| from pkg_resources import Requirement, resource_filename | ||
| from pkg_resources import Requirement |
Contributor
There was a problem hiding this comment.
I think pkg_resources is deprecated so we want to get rid of this. I would put pkg_resources fixes on a separate PR tbh.
|
|
||
| # Resolve APPDATADIR base path to application data files. | ||
| _mydir = os.path.abspath(resource_filename(__name__, "")) | ||
| _mydir = os.path.abspath(str(resources.files(__name__).joinpath(""))) |
Contributor
There was a problem hiding this comment.
whenever we touch lines of code that do path munging, switch the code to using pathlib.Path. Then do it for the full module. This also on a separate PR because it will be harder to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sbillinge second half of commits for modified files