Skip to content

Conversation

@bobleesj
Copy link
Contributor

@bobleesj bobleesj commented Sep 25, 2024

Closes #209, #207, #175, #162, #37

Copy link
Contributor Author

@bobleesj bobleesj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking into the CI tests.

@bobleesj
Copy link
Contributor Author

bobleesj commented Sep 25, 2024

Seems like there is a typo of xport instead of export in https://github.com/Billingegroup/release-scripts/blob/main/.github/workflows/_tests-on-pr.yml

      - name: Validate ${{ inputs.project }}
        run: |
          if ${{ inputs.headless }}; then
            xport DISPLAY=:99

Created a PR: scikit-package/release-scripts#45

Once the PR is merged, hopefully the CI passes.

diffpy.structure
diffpy.utils
matplotlib-base
numpy
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed pinning since the latest release on conda-forge (diffpy.structure, diffpy.pdffit2 have no numpy pinning)

Copy link
Contributor Author

@bobleesj bobleesj Sep 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In proproject.toml, however, still maintained below as discussed regarding the wx problem.

        'Programming Language :: Python :: 3.10',
        'Programming Language :: Python :: 3.11',

@bobleesj
Copy link
Contributor Author

@sbillinge Just noticed that xport to export typo must be also fixed in v0 of the release script as well as main. Created a PR: scikit-package/release-scripts#46

@sbillinge
Copy link
Contributor

I reran the tests after merging main into v0 and the tests failed in the same way. @bobleesj Pls could you take a quick look. I think it is probably something very simple.

@bobleesj
Copy link
Contributor Author

(Still running tests using my own local fork) I will ping @sbillinge once ready for review.

@bobleesj
Copy link
Contributor Author

I think it's ready @sbillinge Had to pin numpy < 2 but made an issue

#212

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move tests folder to root level

2 participants