Fix Atom attributes crash on numpy int values #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expose failed conversion.
Handle numpy.int types which have no built-in converters in boost python.
No need for conversion, numpy types are to be handled by Atom class.
Accept numpy types as float-convertible values for Atom attributes.
pavoljuhas
force-pushed
the
fix-atom-crash-on-numpy-int
branch
from
a0f9ba6 to
08f0f19
Compare
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
==========================================
+ Coverage 98.7% 98.71% +<.01%
==========================================
Files 45 45
Lines 3792 3820 +28
==========================================
+ Hits 3743 3771 +28
Misses 49 49
Continue to review full report at Codecov.
|
pavoljuhas
added a commit
that referenced
this pull request
Apr 26, 2019
* add conversion utility extractdouble * use `extractdouble` to convert Atom attributes Close #20.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI reports only - do not merge