Remove 6 pytest warnings with capturing wavelength warnings #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #259 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 380 386 +6
=========================================
+ Hits 380 386 +6
|
sbillinge
reviewed
Dec 20, 2024
Contributor
sbillinge
left a comment
sbillinge
left a comment
There was a problem hiding this comment.
code is good here so I will merge to keep things going, but please see the comments on the news.
| @@ -0,0 +1,23 @@ | |||
| **Added:** | |||
|
|
|||
| * No news added | |||
Contributor
There was a problem hiding this comment.
please use something like:
* no news added: intercepting warnings generated by tests on purpose not needed by users or devs.
With that said, I think this probably would be good to hvae a news.....
Contributor
Author
There was a problem hiding this comment.
Yup noted. There are other remaining warnings, etc. I will include that news item
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making smaller PRs since @sbillinge is on the road.