added a json flag

[vdbaan]

Added this json flag so that the output of pipal can be used in a pipeline.

[digininja]

I like the idea, but not the way it is implemented. Copy/paste on the whole get_results functions gives a lot of redundant code and a high chance of things getting out of sync if a change is made to one of the functions but not the other.

There is also data missing from the JSON, for example around line 390 on the basic checker, you've commented out the string output but not replaced it with JSON output.

I'm happy to add JSON output, I just think it needs doing in a more generic way. Maybe change the main get_results to return JSON and then parse that into text if that is what is required. That way, if someone a different style of output they could add a new JSON parser to create whatever they wanted.

Sorry to be negative, but I just don't like the idea of supporting so much repeated code, even though there hasn't really been any changes to the checkers for a long time.

[vdbaan]

I don't see it as negative comment, but constructive.

I would recommend not changing the output of get_results to json as that could mess up the other checkers, but to made it call get_json_output and then show the output from that as it would normally.

And thanks for the catch on line 390, will amend that.

[digininja]

I would recommend not changing the output of get_results to json as that could mess up the other checkers, but to made it call get_json_output and then show the output from that as it would normally.

That would work as well.

[vdbaan]

Reworked get_results to print based on the get_json_results.