refactor: remove dead TCP bridge code, clean up for LCM-only transport#3
Merged
spomichter merged 1 commit intofeat/lcm-click-transportfrom Mar 3, 2026
Merged
Conversation
- remove python_bridge/ directory (TCP bridge replaced by LCM) - remove interaction/sender.rs (TCP event sender, unused) - remove ControlViewer connection (port 8889) - remove Control panel wrapper (old demo UI) - simplify protocol.rs: keep only Click variant - simplify handle.rs: keep only send_click - clean up build-viewer.yml: fix paths, update action versions (v4) - rename app env to 'DimOS Interactive Viewer' - final Box::new(rerun_app) instead of Control::new wrapper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exact same cleanup as PR #1's
e3e4ff4baccommit, applied to the LCM branch so it can merge clean into main.Removes:
python_bridge/directory (6 files — TCP bridge replaced by LCM)interaction/sender.rs(TCP event sender)ControlViewerconnection (port 8889)Controlpanel wrapper (old demo UI)Simplifies:
protocol.rs— keep onlyClickvariant (dropWaypointComplete,ModeChanged,Disconnect,AppCommand)handle.rs— keep onlysend_click(dropsend_waypoint_complete,send_mode_changed,send_disconnect)mod.rs— dropsendermodule and exportsUpdates:
build-viewer.yml— fix paths, update actions to v4, drop python bridge test stepsviewer.rs—Box::new(rerun_app)instead ofControl::new(), app env → 'DimOS Interactive Viewer'Result: After this merges, PR #2 is clean LCM-only and ready to merge straight into main.
12 files changed, +93 / -2008