Skip to content

Remove unnecessary serialization of Python functions #1121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paul-nechifor merged 1 commit into from
Jan 27, 2026
Merged

Remove unnecessary serialization of Python functions #1121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions dimos/core/rpc_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@


class RpcCall:
_original_method: Callable[..., Any] | None
_rpc: LCMRPC | None
_name: str
_remote_name: str
Expand All @@ -38,7 +37,6 @@ def __init__(
unsub_fns: list, # type: ignore[type-arg]
stop_client: Callable[[], None] | None = None,
) -> None:
self._original_method = original_method
self._rpc = rpc
self._name = name
self._remote_name = remote_name
Expand Down Expand Up @@ -71,10 +69,10 @@ def __call__(self, *args, **kwargs): # type: ignore[no-untyped-def]
return result

def __getstate__(self): # type: ignore[no-untyped-def]
return (self._original_method, self._name, self._remote_name)
return (self._name, self._remote_name)

def __setstate__(self, state) -> None: # type: ignore[no-untyped-def]
self._original_method, self._name, self._remote_name = state
self._name, self._remote_name = state
self._unsub_fns = []
self._rpc = None
self._stop_rpc_client = None
Expand Down