Skip to content

test: md-only PR to verify ci-complete gate#1283

Closed
spomichter wants to merge 2 commits intodevfrom
test/ci-gate-verify
Closed

test: md-only PR to verify ci-complete gate#1283
spomichter wants to merge 2 commits intodevfrom
test/ci-gate-verify

Conversation

@spomichter
Copy link
Contributor

Pure md-only change branched off dev (after ci-complete gate merged). Verifies that:

  1. Workflow triggers (no paths-ignore blocking it)
  2. check-changes correctly detects no code changes
  3. Test jobs run but skip all steps via should-run=false
  4. ci-complete gate passes

Do NOT merge — delete after verification.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 17, 2026

Greptile Summary

adds a test markdown file (docs/ci-gate-test.md) to verify the ci-complete gate workflow handles md-only PRs correctly - specifically testing that check-changes detects no code changes and test jobs skip properly via should-run=false

  • Critical syntax error: file contains literal \n characters instead of actual newlines, causing the entire content to render on a single line
  • Per PR description, this is a temporary test PR meant for deletion after verification
  • aligns with the recently merged ci-complete gate in ci: dynamic branch protection via ci-complete gate #1279

Confidence Score: 2/5

  • safe for testing purposes but contains a syntax error that should be fixed
  • score reflects that while this is a low-risk test PR (md-only change), the file has a critical formatting issue with literal \n characters that will render incorrectly - needs correction before the test is meaningful
  • docs/ci-gate-test.md requires fixing the newline syntax

Important Files Changed

Filename Overview
docs/ci-gate-test.md adds test doc for ci-complete gate verification, but contains literal \n instead of newlines

Last reviewed commit: a00fd81

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@@ -0,0 +1 @@
# CI Gate Test\n\nThis file exists solely to test that md-only PRs pass the ci-complete gate without running the full test suite.\n\nDelete after verification.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

literal \n instead of actual newlines - renders as single line with visible \n characters

Suggested change
# CI Gate Test\n\nThis file exists solely to test that md-only PRs pass the ci-complete gate without running the full test suite.\n\nDelete after verification.
# CI Gate Test
This file exists solely to test that md-only PRs pass the ci-complete gate without running the full test suite.
Delete after verification.

…job results

The test caller should-run expressions relied on dev.result == 'success'
to determine if tests should run. But with if: always() on build jobs,
the reusable workflow reports 'success' even when should-run=false and
all steps are skipped. This caused md-only PRs to trigger the full
test suite.

Replace upstream result checks with direct path filter output checks:
- Non-ROS tests: tests || python || dev
- ROS tests + mypy: tests || ros || python || dev

This correctly evaluates to false when only .md files change.
@spomichter
Copy link
Contributor Author

Closing — recreating as clean PR with only the should-run fix, no test files.

@spomichter spomichter closed this Feb 17, 2026
@spomichter spomichter deleted the test/ci-gate-verify branch February 17, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant