test: md-only PR to verify ci-complete gate#1283
Closed
spomichter wants to merge 2 commits intodevfrom
Closed
Conversation
Contributor
Greptile Summaryadds a test markdown file (
Confidence Score: 2/5
Important Files Changed
Last reviewed commit: a00fd81 |
| @@ -0,0 +1 @@ | |||
| # CI Gate Test\n\nThis file exists solely to test that md-only PRs pass the ci-complete gate without running the full test suite.\n\nDelete after verification. | |||
Contributor
There was a problem hiding this comment.
literal \n instead of actual newlines - renders as single line with visible \n characters
Suggested change
| # CI Gate Test\n\nThis file exists solely to test that md-only PRs pass the ci-complete gate without running the full test suite.\n\nDelete after verification. | |
| # CI Gate Test | |
| This file exists solely to test that md-only PRs pass the ci-complete gate without running the full test suite. | |
| Delete after verification. |
…job results The test caller should-run expressions relied on dev.result == 'success' to determine if tests should run. But with if: always() on build jobs, the reusable workflow reports 'success' even when should-run=false and all steps are skipped. This caused md-only PRs to trigger the full test suite. Replace upstream result checks with direct path filter output checks: - Non-ROS tests: tests || python || dev - ROS tests + mypy: tests || ros || python || dev This correctly evaluates to false when only .md files change.
Contributor
Author
|
Closing — recreating as clean PR with only the should-run fix, no test files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure md-only change branched off
dev(after ci-complete gate merged). Verifies that:paths-ignoreblocking it)check-changescorrectly detects no code changesshould-run=falseci-completegate passesDo NOT merge — delete after verification.