Skip to content

test: md-only PR to verify ci-complete gate #1285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spomichter wants to merge 2 commits into from
Closed

test: md-only PR to verify ci-complete gate #1285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d67c627
test: md-only change to verify ci-complete gate
spomichter Feb 17, 2026
2837432
fix(ci): skip test jobs entirely for non-code PRs, add builds to ci-c…
spomichter Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 45 additions & 7 deletions .github/workflows/docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,14 @@ jobs:

run-ros-tests:
needs: [check-changes, ros-dev]
if: always()
if: ${{
always() &&
needs.check-changes.result == 'success' &&
(needs.check-changes.outputs.tests == 'true' ||
needs.check-changes.outputs.ros == 'true' ||
needs.check-changes.outputs.python == 'true' ||
needs.check-changes.outputs.dev == 'true')
}}
uses: ./.github/workflows/tests.yml
secrets: inherit
with:
Expand All @@ -160,7 +167,13 @@ jobs:

run-tests:
needs: [check-changes, dev]
if: always()
if: ${{
always() &&
needs.check-changes.result == 'success' &&
(needs.check-changes.outputs.tests == 'true' ||
needs.check-changes.outputs.python == 'true' ||
needs.check-changes.outputs.dev == 'true')
}}
uses: ./.github/workflows/tests.yml
secrets: inherit
with:
Expand All @@ -176,7 +189,13 @@ jobs:
# we run in parallel with normal tests for speed
run-heavy-tests:
needs: [check-changes, dev]
if: always()
if: ${{
always() &&
needs.check-changes.result == 'success' &&
(needs.check-changes.outputs.tests == 'true' ||
needs.check-changes.outputs.python == 'true' ||
needs.check-changes.outputs.dev == 'true')
}}
uses: ./.github/workflows/tests.yml
secrets: inherit
with:
Expand All @@ -191,7 +210,13 @@ jobs:

run-lcm-tests:
needs: [check-changes, dev]
if: always()
if: ${{
always() &&
needs.check-changes.result == 'success' &&
(needs.check-changes.outputs.tests == 'true' ||
needs.check-changes.outputs.python == 'true' ||
needs.check-changes.outputs.dev == 'true')
}}
uses: ./.github/workflows/tests.yml
secrets: inherit
with:
Expand All @@ -206,7 +231,13 @@ jobs:

run-integration-tests:
needs: [check-changes, dev]
if: always()
if: ${{
always() &&
needs.check-changes.result == 'success' &&
(needs.check-changes.outputs.tests == 'true' ||
needs.check-changes.outputs.python == 'true' ||
needs.check-changes.outputs.dev == 'true')
}}
uses: ./.github/workflows/tests.yml
secrets: inherit
with:
Expand All @@ -221,7 +252,14 @@ jobs:

run-mypy:
needs: [check-changes, ros-dev]
if: always()
if: ${{
always() &&
needs.check-changes.result == 'success' &&
(needs.check-changes.outputs.tests == 'true' ||
needs.check-changes.outputs.ros == 'true' ||
needs.check-changes.outputs.python == 'true' ||
needs.check-changes.outputs.dev == 'true')
}}
uses: ./.github/workflows/tests.yml
secrets: inherit
with:
Expand Down Expand Up @@ -271,7 +309,7 @@ jobs:
# /entrypoint.sh bash -c "pytest -m module"
Copy link
Contributor

@greptile-apps greptile-apps bot Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ci-complete does not catch check-changes failures

ci-complete's needs list does not include check-changes directly. If check-changes fails, all downstream jobs that don't use if: always() (e.g. ros, python) are automatically skipped by GitHub Actions — they won't appear as failure in needs.*.result. As a result, a check-changes failure would cause ci-complete to pass (no failure or cancelled in its direct dependencies), silently swallowing the infrastructure failure.

Consider adding check-changes to ci-complete's needs list:

needs: [check-changes, ros, python, ros-python, dev, ros-dev, run-tests, run-heavy-tests, run-lcm-tests, run-integration-tests, run-ros-tests, run-mypy]

This is a pre-existing gap, but the expansion of ci-complete's needs in this PR is a good opportunity to close it.


ci-complete:
needs: [run-tests, run-heavy-tests, run-lcm-tests, run-integration-tests, run-ros-tests, run-mypy]
needs: [ros, python, ros-python, dev, ros-dev, run-tests, run-heavy-tests, run-lcm-tests, run-integration-tests, run-ros-tests, run-mypy]
runs-on: [self-hosted, Linux]
if: always()
steps:
Expand Down
4 changes: 4 additions & 0 deletions docs/ci-gate-test.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# CI Gate Verification

Test file to verify md-only PRs skip the test suite and pass ci-complete.
Delete after verification.
Comment on lines +1 to +4
Copy link
Contributor

@greptile-apps greptile-apps bot Feb 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporary file not deleted after verification

The file itself says "Delete after verification." Since this PR also changes docker.yml (which is tracked by the ros and python path filters), the CI run for this PR will trigger full builds and tests — it won't self-verify the md-only skip behavior described in the PR description. A follow-up PR with only an .md change would be needed to observe the skipping logic in action.

If this file is being kept as a persistent example or documentation, the "Delete after verification" note should be removed. Otherwise, this file should be removed before merge.

Loading