-
Notifications
You must be signed in to change notification settings - Fork 153
feat(dask): remove dask #1365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat(dask): remove dask #1365
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -71,3 +71,4 @@ CLAUDE.MD | |
| /assets/teleop_certs/ | ||
|
|
||
| /.mcp.json | ||
| *.speedscope.json | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -21,8 +21,7 @@ | |
| from dimos.core.core import rpc | ||
| from dimos.core.module import Module | ||
| from dimos.core.stream import In | ||
| from dimos.models.qwen.video_query import BBox | ||
| from dimos.models.vl.qwen import QwenVlModel | ||
| from dimos.models.qwen.bbox import BBox | ||
| from dimos.msgs.geometry_msgs import PoseStamped, Quaternion, Vector3 | ||
| from dimos.msgs.geometry_msgs.Vector3 import make_vector3 | ||
| from dimos.msgs.sensor_msgs import Image | ||
|
|
@@ -59,6 +58,10 @@ class NavigationSkillContainer(Module): | |
| def __init__(self) -> None: | ||
| super().__init__() | ||
| self._skill_started = False | ||
|
|
||
| # Here to prevent unwanted imports in the file. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. and here |
||
| from dimos.models.vl.qwen import QwenVlModel | ||
|
|
||
| self._vl_model = QwenVlModel() | ||
|
|
||
| @rpc | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,8 +26,7 @@ | |
| from dimos.core.global_config import GlobalConfig | ||
| from dimos.core.module import Module | ||
| from dimos.core.stream import In, Out | ||
| from dimos.models.qwen.video_query import BBox | ||
| from dimos.models.segmentation.edge_tam import EdgeTAMProcessor | ||
| from dimos.models.qwen.bbox import BBox | ||
| from dimos.models.vl.qwen import QwenVlModel | ||
| from dimos.msgs.geometry_msgs import Twist | ||
| from dimos.msgs.sensor_msgs import CameraInfo, Image, PointCloud2 | ||
|
|
@@ -37,6 +36,7 @@ | |
| from dimos.utils.logging_config import setup_logger | ||
|
|
||
| if TYPE_CHECKING: | ||
| from dimos.models.segmentation.edge_tam import EdgeTAMProcessor | ||
| from dimos.models.vl.base import VlModel | ||
|
|
||
| logger = setup_logger() | ||
|
|
@@ -176,6 +176,9 @@ def _follow_person(self, query: str, initial_bbox: BBox) -> str: | |
|
|
||
| with self._lock: | ||
| if self._tracker is None: | ||
| # Here to prevent unwanted imports in the file. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. and here |
||
| from dimos.models.segmentation.edge_tam import EdgeTAMProcessor | ||
|
|
||
| self._tracker = EdgeTAMProcessor() | ||
| tracker = self._tracker | ||
| latest_image = self._latest_image | ||
|
|
@@ -202,7 +205,7 @@ def _follow_person(self, query: str, initial_bbox: BBox) -> str: | |
| "the 'stop_following' tool." | ||
| ) | ||
|
|
||
| def _follow_loop(self, tracker: EdgeTAMProcessor, query: str) -> None: | ||
| def _follow_loop(self, tracker: "EdgeTAMProcessor", query: str) -> None: | ||
| lost_count = 0 | ||
| period = 1.0 / self._frequency | ||
| next_time = time.monotonic() | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paul-nechifor I assume LLM generated comments its on every import shift. not useful and looks ugly
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They're not LLM generated. I specifically added them there to indicate that those imports should not be moved to the top because they cause imports (like that of torch) which slow down the start of
dimos run.Without those comments, people might move them to the top. I often move unnecessary local imports because they're added by LLMs. LLMs often prefer to add local imports because they have the habit of producing the smallest diff possible, even when it doesn't make sense.