Skip to content

fix(protobuf): pin major#1374

Closed
paul-nechifor wants to merge 1 commit intomainfrom
paul/fix/pin-protobuf-major-main
Closed

fix(protobuf): pin major#1374
paul-nechifor wants to merge 1 commit intomainfrom
paul/fix/pin-protobuf-major-main

Conversation

@paul-nechifor
Copy link
Contributor

Same as #1372 but to main

leshy
leshy previously approved these changes Feb 27, 2026
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 27, 2026

Greptile Summary

This PR explicitly pins the protobuf dependency to major version 6 (>=6.33.5,<7), preventing automatic upgrades to the upcoming v7 which may contain breaking changes.

Changes:

  • Added protobuf>=6.33.5,<7 to core dependencies in pyproject.toml
  • Updated uv.lock with the explicit dependency

Context:

  • protobuf is already a transitive dependency through packages like rerun-sdk, onnxruntime, and tensorboardx
  • Making it explicit ensures version control and stability
  • Aligns with existing types-protobuf>=6.32.1.20250918,<7 dev dependency
  • No code changes required, purely dependency management

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • This is a defensive dependency management change that explicitly pins an already-used transitive dependency. Version 6.33.5 is already present in the lock file, and the major version constraint (<7) prevents breaking changes. No code changes, no logic changes, and aligns with existing type stub versioning.
  • No files require special attention

Important Files Changed

Filename Overview
pyproject.toml Added explicit protobuf dependency with major version pin (>=6.33.5,<7) to prevent breaking changes from v7 upgrade
uv.lock Lock file updated to reflect explicit protobuf dependency at version 6.33.5

Last reviewed commit: 532d4e8

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@paul-nechifor
Copy link
Contributor Author

Closed as I've already released the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants