Skip to content

chore: remove unnecessary "prevent unwanted imports" comments#1379

Closed
spomichter wants to merge 1 commit intodevfrom
chore/remove-llm-comments
Closed

chore: remove unnecessary "prevent unwanted imports" comments#1379
spomichter wants to merge 1 commit intodevfrom
chore/remove-llm-comments

Conversation

@spomichter
Copy link
Contributor

How to Run/Test

cd /home/ubuntu/dimos
git fetch origin
git checkout chore/remove-llm-comments
grep -rn "Here to prevent unwanted imports" --include="*.py"
# Should return nothing

Summary

Removes 8 instances of the LLM-generated comment # Here to prevent unwanted imports in the file. that were introduced in PR #1365. The lazy imports themselves are correct and intentional — only the redundant comments are removed.

Reference: https://github.com/dimensionalOS/dimos/pull/1365/changes#r2867298612

Changes

  • Removed comment from dimos/agents/agent.py (line 106)
  • Removed comment from dimos/agents/skills/navigation.py (line 62)
  • Removed comment from dimos/agents/skills/person_follow.py (line 179)
  • Removed comment from dimos/agents/web_human_input.py (line 55)
  • Removed comment from dimos/agents_deprecated/memory/spatial_vector_db.py (line 59)
  • Removed 3 comments from dimos/models/vl/base.py (lines 72, 258, 319)

Testing

  • Pre-commit hooks pass (all 18 checks)
  • No functional code changed — comment-only removal
  • Verified zero remaining instances via grep

Remove 8 instances of the LLM-generated comment "# Here to prevent unwanted
imports in the file." introduced in PR #1365. The lazy imports themselves are
fine; only the redundant comments are removed.
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 28, 2026

Greptile Summary

This PR removes 8 instances of the redundant LLM-generated comment "Here to prevent unwanted imports in the file" that was introduced in PR #1365. The lazy imports themselves remain intact and functional.

  • All changes are comment-only removals with zero impact on code behavior
  • Pre-commit hooks pass successfully
  • Author verified no remaining instances via grep

Confidence Score: 5/5

  • This PR is completely safe to merge with zero risk
  • Only removes redundant comments with no functional code changes, pre-commit hooks pass, and the change improves code cleanliness by removing unnecessary LLM-generated comments
  • No files require special attention

Important Files Changed

Filename Overview
dimos/agents/agent.py Removed 1 redundant comment from lazy import block
dimos/agents/skills/navigation.py Removed 1 redundant comment from lazy import block
dimos/agents/skills/person_follow.py Removed 1 redundant comment from lazy import block
dimos/agents/web_human_input.py Removed 1 redundant comment from lazy import block
dimos/agents_deprecated/memory/spatial_vector_db.py Removed 1 redundant comment from lazy import block
dimos/models/vl/base.py Removed 3 redundant comments from lazy import blocks

Last reviewed commit: 49ab5fd

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@paul-nechifor
Copy link
Contributor

paul-nechifor commented Feb 28, 2026

Removes 8 instances of the LLM-generated comment # Here to prevent unwanted imports in the file.

They're not LLM generated. I specifically added them there to indicate that those imports should not be moved to the top because they cause imports which slow down the start of dimos run.

Without those comments, people might move them to the top. I often move unnecessary local imports because they're added by LLMs. LLMs often prefer to add local imports because they have the habit of producing the smallest diff possible, even when it doesn't make sense.

@spomichter spomichter closed this Feb 28, 2026
@spomichter spomichter deleted the chore/remove-llm-comments branch February 28, 2026 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants