Skip to content

chore(ci): decouple python deps from docker images #1380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spomichter merged 2 commits into from
Mar 1, 2026
Merged

chore(ci): decouple python deps from docker images #1380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0bda65
chore(ci): decouple python deps from docker images
spomichter Feb 28, 2026
73d248c
revert: remove Open3D exit code workaround
spomichter Mar 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .github/workflows/docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ jobs:
- .github/workflows/_docker-build-template.yml
- .github/workflows/docker.yml
- docker/python/**
- pyproject.toml
dev:
- docker/dev/**
Expand Down Expand Up @@ -199,7 +198,7 @@ jobs:
to-image: ghcr.io/dimensionalos/ros-dev:${{ needs.check-changes.outputs.branch-tag }}
dockerfile: dev

run-ros-tests:
run-tests:
needs: [check-changes, ros-dev]
if: ${{
always() &&
Expand Down Expand Up @@ -232,7 +231,7 @@ jobs:
dev-image: ros-dev:${{ (needs.check-changes.outputs.python == 'true' || needs.check-changes.outputs.dev == 'true' || needs.check-changes.outputs.ros == 'true') && needs.ros-dev.result == 'success' && needs.check-changes.outputs.branch-tag || 'dev' }}

ci-complete:
needs: [check-changes, ros, python, ros-python, dev, ros-dev, run-ros-tests, run-mypy]
needs: [check-changes, ros, python, ros-python, dev, ros-dev, run-tests, run-mypy]
runs-on: [self-hosted, Linux]
if: always()
steps:
Expand Down
9 changes: 8 additions & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,16 @@ jobs:
run: |
git config --global --add safe.directory '*'
- name: Install Python dependencies
run: uv sync --all-extras --no-extra dds --frozen

- name: Remove pydrake stubs
run: |
find .venv/lib/*/site-packages/pydrake -name '*.pyi' -delete 2>/dev/null || true
- name: Run tests
run: |
/entrypoint.sh bash -c "${{ inputs.cmd }}"
/entrypoint.sh bash -c "source .venv/bin/activate && ${{ inputs.cmd }}"
- name: check disk space
if: failure()
Expand Down
3 changes: 0 additions & 3 deletions docker/dev/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,6 @@ ENV UV_SYSTEM_PYTHON=1
RUN curl -LsSf https://astral.sh/uv/install.sh | sh
ENV PATH="/root/.local/bin:$PATH"

# Install dependencies with UV
RUN uv pip install .[dev]

# Copy files and add version to motd
COPY /assets/dimensionalascii.txt /etc/motd
COPY /docker/dev/bash.sh /root/.bash.sh
Expand Down
10 changes: 0 additions & 10 deletions docker/python/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,3 @@ RUN curl -LsSf https://astral.sh/uv/install.sh | sh
ENV PATH="/root/.local/bin:$PATH"

WORKDIR /app

# Copy entire project first to ensure proper package installation
COPY . /app/

# Install dependencies with UV (10-100x faster than pip)
RUN uv pip install --upgrade 'pip>=24' 'setuptools>=70' 'wheel' 'packaging>=24' && \
uv pip install '.[misc,cpu,sim,drone,unitree,web,perception,visualization,manipulation]'

# Remove pydrake .pyi stubs that use Python 3.12 syntax (breaks mypy on 3.10)
RUN find /usr/local/lib/python3.10/dist-packages/pydrake -name '*.pyi' -delete
Loading