Skip to content

fix: increase RPC test timeout - CI flaky issue#1383

Merged
paul-nechifor merged 1 commit intodevfrom
ruthwik/fix/CI_rpc_tests_timeout
Feb 28, 2026
Merged

fix: increase RPC test timeout - CI flaky issue#1383
paul-nechifor merged 1 commit intodevfrom
ruthwik/fix/CI_rpc_tests_timeout

Conversation

@ruthwikdasyam
Copy link
Contributor

@ruthwikdasyam ruthwikdasyam commented Feb 28, 2026

Problem

test_exception_handling_sync[lcm_rpc_context-lcm] fails intermittently in CI with TimeoutError after 2.0s. LCM multicast discovery + RPC round-trip can exceed 2s on loaded CI runners.

#1381
Closes DIM-642

Solution

Increase rpc_timeout from 2.0s to 5.0s for all three call_sync invocations in the test. Only affects failure path - passing tests return instantly.

Breaking Changes

None

How to Test

pytest dimos/protocol/rpc/test_spec.py::test_exception_handling_sync -v

Contributor License Agreement

  • I have read and approved the CLA.

@ruthwikdasyam ruthwikdasyam changed the title fix: increase RPC test timeout to reduce CI flakiness fix: increase RPC test timeout - CI flaky issue Feb 28, 2026
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 28, 2026

Greptile Summary

Increased rpc_timeout from 2.0s to 5.0s in test_exception_handling_sync to address intermittent CI failures caused by LCM multicast discovery + RPC round-trip exceeding 2s on loaded CI runners.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk - it only adjusts test timeout configuration
  • Simple, targeted fix that increases test timeout to address CI flakiness; no production code changes, no logical changes to test behavior
  • No files require special attention

Important Files Changed

Filename Overview
dimos/protocol/rpc/test_spec.py Increased RPC timeout from 2.0s to 5.0s in test_exception_handling_sync to address CI flakiness

Last reviewed commit: 492df1a

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@paul-nechifor paul-nechifor merged commit bc541f0 into dev Feb 28, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants