Skip to content

env/devcontainer ruff formatting/typing #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
leshy merged 3 commits into from
May 22, 2025
+37 −2
Merged

env/devcontainer ruff formatting/typing #294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4da79c0
feat(env): devcontainer-ruff implementation
leshy May 22, 2025
0c7a603
including mypy and ruff in the dev image
leshy May 22, 2025
c99adbc
fixed dev-requirements syntax
leshy May 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,26 @@
{
"name": "dimos-dev",
"image": "ghcr.io/dimensionalos/dimos-dev:latest",
"postCreateCommand": "pre-commit install",
"image": "ghcr.io/dimensionalos/dev:dev",
Copy link
Contributor

@spomichter spomichter May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an issue jacob mentioned as this image isn't public, so he can't use. TODO on my end.

Copy link
Contributor Author

@leshy leshy May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aha didn't know people are actually using our dev images. yeah I have no permission access

"customizations": {
"vscode": {
"extensions": [
"charliermarsh.ruff",
"ms-python.vscode-pylance"
]
}
},

"settings": {
"notebook.formatOnSave.enabled": true,
"notebook.codeActionsOnSave": {
"notebook.source.fixAll": "explicit",
"notebook.source.organizeImports": "explicit"
},
"editor.codeActionsOnSave": {
"source.fixAll": "explicit",
"source.organizeImports": "explicit"
},
"editor.defaultFormatter": "charliermarsh.ruff",
"editor.formatOnSave": true
}
}
3 changes: 3 additions & 0 deletions docker/dev/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ RUN apt-get install -y \
iputils-ping \
wget

COPY docker/dev/dev-requirements.txt /app/
RUN --mount=type=cache,target=/root/.cache/pip pip install -r dev-requirements.txt

# Copy files and add version to motd
COPY motd /etc/motd
COPY /docker/dev/bash.sh /root/.bash.sh
Expand Down
2 changes: 2 additions & 0 deletions docker/dev/dev-requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
ruff==0.11.10
mypy==1.15.0
17 changes: 17 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,23 @@ description = "Powering agentive generalist robotics"

[tool.ruff]
line-length = 120
exclude = [
".git",
".pytest_cache",
".ruff_cache",
".venv",
".vscode",
"__pypackages__",
"_build",
"build",
"dist",
"node_modules",
"site-packages",
"venv",
"libs",
"external",
"src"
]

[tool.pytest.ini_options]
testpaths = ["dimos/robot"]
Expand Down