Skip to content

Fix SHM leak #652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paul-nechifor merged 1 commit into from
Oct 3, 2025
Merged

Fix SHM leak #652

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions dimos/protocol/pubsub/shmpubsub.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,8 @@ def publish(self, topic: str, message: bytes) -> None:
raise ValueError(f"Payload too large: {L} > capacity {st.capacity}")

# Mark this payload to suppress its single echo (handles back-to-back publishes)
st.suppress_counts[payload_bytes] += 1
payload_hash = hashlib.md5(payload_bytes).digest()
st.suppress_counts[payload_hash] += 1

# Synchronous local delivery first (zero extra copies)
for cb in list(st.subs):
Expand Down Expand Up @@ -276,12 +277,13 @@ def _fanout_loop(self, topic: str, st: _TopicState) -> None:
payload = host[4 : 4 + L].tobytes()

# Drop exactly the number of local echoes we created
cnt = st.suppress_counts.get(payload, 0)
payload_hash = hashlib.md5(payload).digest()
cnt = st.suppress_counts.get(payload_hash, 0)
if cnt > 0:
if cnt == 1:
del st.suppress_counts[payload]
del st.suppress_counts[payload_hash]
else:
st.suppress_counts[payload] = cnt - 1
st.suppress_counts[payload_hash] = cnt - 1
continue # suppressed

except Exception:
Expand Down