Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
| opencv-python | ||
| python-dotenv | ||
| openai | ||
| anthropic>=0.19.0 | ||
| cerebras-cloud-sdk |
There was a problem hiding this comment.
The commit removes the root requirements.txt, but many Dockerfiles (e.g. docker/deprecated/agent/Dockerfile and several others under docker/deprecated/*) still execute COPY requirements.txt followed by pip install -r requirements.txt. Any docker build that relies on those files now fails immediately because the referenced file no longer exists. Either restore the file or migrate those Dockerfiles to the new uv workflow before deleting it.
Useful? React with 👍 / 👎.
| "soundfile", | ||
|
|
||
| # PyTorch (version constraints from base-requirements.txt) | ||
| "torch==2.0.1", |
There was a problem hiding this comment.
No we cannot lock torch versions
There was a problem hiding this comment.
following the same constraint as the requirements file.
Line 1 in 753c56a
dev branch with version locks.
| Tested on Ubuntu 22.04/24.04 | ||
|
|
||
| ```bash | ||
| sudo apt install python3-venv |
There was a problem hiding this comment.
redundant. uv venv --python 3.10 replaces it.
| pip install -e .[cpu,dev] | ||
| # Install dependencies | ||
| # CPU only (recommended to attempt first) | ||
| uv sync --extra dev --extra cpu |
There was a problem hiding this comment.
Idk this syntax i usually do uv pip install -e .[cpu] maybe its the same
There was a problem hiding this comment.
uv sync and uv add are more native options from uv. uv sync installs only the subset of dependencies that are missing or have changed, making it faster than checking everything like pip install does.
uv pip install will install the packages in global env if local isn't activated, uv sync needs opt-in. given how specific some dependencies are, we wouldn't want to mess with the system level dependencies accidentally
|
Deprecated docker dir is deprecated and should just be deleted |
|
Superseded by #870 |
3 participants
Installation time with pip: ~4m 02s
Installation time with uv: ~2m 30s
1.6x speedup