Alternative packages organization (helps for follow-up MacOS support)#743
Alternative packages organization (helps for follow-up MacOS support)#743jeff-hykin wants to merge 6 commits intodimensionalOS:mainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
flake.lock
Outdated
| "core": { | ||
| "locked": { | ||
| "lastModified": 1, | ||
| "narHash": "sha256-lWX5DUltOFcS57I8wHH0Sz3J++zMORxHf+CXoZZLQzU=", | ||
| "path": "./helpers/builtins", | ||
| "type": "path" | ||
| }, | ||
| "original": { | ||
| "path": "./helpers/builtins", | ||
| "type": "path" |
There was a problem hiding this comment.
The new flake inputs introduce a core node that points to "./helpers/builtins" and the lock file records it as a path dependency (lines 3‑12). There is no such directory anywhere in the repository, so any nix command (e.g. nix develop) now fails immediately with “error: getting status of ‘…/helpers/builtins’: No such file or directory” before the flake can be evaluated. Please either commit the helpers/builtins directory or point the lock entry to an existing location so that the development environment can be brought up again.
Useful? React with 👍 / 👎.
1 participant
The organization idea is there's always one list of packages, and then we just query subsets out of that list as needed for things like LD_PATH. There's an aggregator tool I wrote that makes it easy to form things like the LD_PATH.
Its also made to support more advanced cases like having a shell-hook associated with a particular package. Ex: the
venvactivation script can be alongside the python package instead of disconnected.