Skip to content

Revert "Added concurrency check"#808

Closed
leshy wants to merge 1 commit intodevfrom
revert-803-add-concurrency-CI
Closed

Revert "Added concurrency check"#808
leshy wants to merge 1 commit intodevfrom
revert-803-add-concurrency-CI

Conversation

@leshy
Copy link
Contributor

@leshy leshy commented Dec 5, 2025

Reverts #803

@chatgpt-codex-connector
Copy link

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 5, 2025

Greptile Overview

Greptile Summary

Reverts the concurrency control added in PR #803 for the Docker workflow. The removed configuration would cancel in-progress workflow runs when a new commit is pushed to the same branch.

  • Removes concurrency block with cancel-in-progress: true from .github/workflows/docker.yml
  • Multiple workflow runs for the same branch can now run in parallel instead of being auto-cancelled
  • May increase CI resource usage but ensures all commits get fully built and tested

Confidence Score: 5/5

  • This PR is safe to merge - it's a clean revert of a small workflow configuration change
  • The change is a straightforward 4-line removal that reverts a recently added feature. No code logic is affected, only CI behavior. The workflow file remains valid YAML with correct structure.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
.github/workflows/docker.yml 5/5 Removes concurrency block that was canceling in-progress workflow runs for the same branch. Clean revert with no issues.

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant GH as GitHub
    participant WF as Docker Workflow
    participant Runner as CI Runner

    Note over Dev,Runner: Before this PR (with concurrency)
    Dev->>GH: Push commit A
    GH->>WF: Trigger workflow run A
    WF->>Runner: Start build A
    Dev->>GH: Push commit B
    GH->>WF: Trigger workflow run B
    WF--xRunner: Cancel build A (in-progress)
    WF->>Runner: Start build B
    Runner-->>GH: Complete build B only

    Note over Dev,Runner: After this PR (without concurrency)
    Dev->>GH: Push commit A
    GH->>WF: Trigger workflow run A
    WF->>Runner: Start build A
    Dev->>GH: Push commit B
    GH->>WF: Trigger workflow run B
    WF->>Runner: Start build B (parallel)
    Runner-->>GH: Complete build A
    Runner-->>GH: Complete build B
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@paul-nechifor
Copy link
Contributor

Not needed anymore as this was not the problem. Closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants