Skip to content

fix set transport #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paul-nechifor merged 1 commit into from
Dec 19, 2025
+2 −2
Merged

fix set transport #866

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dimos/core/module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ def set_ref(self, ref) -> int: # type: ignore[no-untyped-def]
def __str__(self) -> str:
return f"{self.__class__.__name__}"

# called from remote
@rpc
def set_transport(self, stream_name: str, transport: Transport) -> bool: # type: ignore[type-arg]
stream = getattr(self, stream_name, None)
if not stream:
Expand Down
2 changes: 1 addition & 1 deletion dimos/core/test_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ def test_classmethods() -> None:
# Check that we have the expected RPC methods
assert "navigate_to" in class_rpcs, "navigate_to should be in rpcs"
assert "start" in class_rpcs, "start should be in rpcs"
assert len(class_rpcs) == 8
assert len(class_rpcs) == 9

# Check that the values are callable
assert callable(class_rpcs["navigate_to"]), "navigate_to should be callable"
Expand Down