Skip to content

TEST Revert "Feat/rerun latency panels"#926

Closed
leshy wants to merge 1 commit intodevfrom
revert-917-feat/rerun-latency-panels
Closed

TEST Revert "Feat/rerun latency panels"#926
leshy wants to merge 1 commit intodevfrom
revert-917-feat/rerun-latency-panels

Conversation

@leshy
Copy link
Contributor

@leshy leshy commented Jan 2, 2026

Reverts #917

@chatgpt-codex-connector
Copy link

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@leshy leshy closed this Jan 2, 2026
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 2, 2026

Greptile Summary

This PR reverts #917, removing the Rerun latency panels feature and all associated Rerun visualization integration.

Major Changes:

  • Removed autolog_to_rerun() functionality from Out class in dimos/core/stream.py
  • Removed Rerun blueprint initialization and server startup from dimos/core/blueprints.py
  • Removed viewer backend configuration (viewer_backend, rerun_enabled) from GlobalConfig
  • Deleted dimos/dashboard/rerun_init.py (Rerun multi-process initialization)
  • Removed to_rerun() visualization methods from message types (OccupancyGrid, etc.)
  • Removed rerun-sdk dependency from pyproject.toml
  • Deleted documentation file docs/VIEWER_BACKENDS.md
  • Removed latency metrics tracking from mapping modules

Impact:
The revert is clean with no leftover references to removed functionality. All Rerun imports, method calls, and configuration options have been properly removed.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk - clean revert with no residual code
  • This is a straightforward git revert that cleanly removes all Rerun integration code. The revert successfully removes all imports, method calls, and configuration without leaving any dangling references. No syntax errors or logical issues found.
  • No files require special attention

Important Files Changed

Filename Overview
dimos/core/stream.py Removed Rerun integration (autolog_to_rerun, ObservableMixin from Out class), clean revert
dimos/core/blueprints.py Removed Rerun blueprint initialization and server startup logic, clean revert
dimos/core/global_config.py Removed viewer backend configuration options (rerun_enabled, viewer_backend fields)
dimos/dashboard/rerun_init.py File deleted - contained Rerun initialization and multi-process support code
dimos/msgs/nav_msgs/OccupancyGrid.py Removed to_rerun() visualization methods and matplotlib/rerun dependencies
pyproject.toml Removed rerun-sdk dependency and go2 URDF package data entry
docs/VIEWER_BACKENDS.md Documentation file deleted - described Rerun viewer backend options

Sequence Diagram

sequenceDiagram
    participant User
    participant PR as PR #926 Revert
    participant Core as Core Components
    participant Stream as Stream (Out class)
    participant Blueprint as Blueprint System
    participant Config as Global Config
    participant Msgs as Message Types
    participant Deps as Dependencies

    User->>PR: Revert PR #917
    PR->>Stream: Remove autolog_to_rerun()
    PR->>Stream: Remove ObservableMixin from Out
    PR->>Stream: Remove _rerun_config tracking
    PR->>Blueprint: Remove _init_rerun_blueprint()
    PR->>Blueprint: Remove Rerun server init
    PR->>Blueprint: Remove rerun imports
    PR->>Config: Remove viewer_backend field
    PR->>Config: Remove rerun_enabled flag
    PR->>Msgs: Remove to_rerun() methods
    PR->>Msgs: Remove matplotlib/rerun deps
    PR->>Deps: Remove rerun-sdk from pyproject.toml
    PR->>Core: Delete rerun_init.py
    PR->>Core: Delete VIEWER_BACKENDS.md
    Core-->>User: Clean state restored
Loading

@leshy leshy reopened this Jan 2, 2026
@leshy leshy closed this Jan 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant