Skip to content

actually fix uv.lock#965

Closed
paul-nechifor wants to merge 1 commit intodevfrom
actually-fix-uv-lock
Closed

actually fix uv.lock#965
paul-nechifor wants to merge 1 commit intodevfrom
actually-fix-uv-lock

Conversation

@paul-nechifor
Copy link
Contributor

No description provided.

@paul-nechifor paul-nechifor requested a review from a team January 9, 2026 00:31
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Greptile Summary

This PR fixes the uv.lock file by reverting multiple packages from versions with impossible future upload timestamps (2026-01-08) to properly dated earlier versions. The previous PR (#964) added a lock file containing packages that claimed to be uploaded in the future, indicating they were either generated with an incorrect system clock or contained corrupted metadata.

Key Changes

Package Downgrades:

  • bitsandbytes: 0.49.1 → 0.49.0
  • build: 1.4.0 → 1.3.0
  • jsonschema: 4.26.0 → 4.25.1
  • jupyter-client: 8.8.0 → 8.7.0
  • langchain: 1.2.3 → 1.2.1
  • langchain-openai: 1.1.7 → 1.1.6
  • langsmith: 0.6.2 → 0.6.1
  • playground: 0.1.0 → 0.0.5
  • plotly: 6.5.1 → 6.5.0
  • pyglet: 2.1.12 → 2.1.11
  • rerun-sdk: 0.28.2 → 0.28.1
  • trimesh: 4.11.0 → 4.10.1
  • ultralytics: 8.3.250 → 8.3.248
  • urllib3: 2.6.3 → 2.6.2

Dependency Removals from playground:

  • Removed absl-py, mediapy, orbax-checkpoint, warp-lang
  • These were transitive dependencies in the newer version that are no longer needed

Platform Marker Changes:

  • Added sys_platform != 'win32' exclusions to several NVIDIA CUDA and bitsandbytes dependencies
  • More restrictive platform targeting for Linux-specific packages

Critical Issue:
The exceptiongroup package dependency marker was changed from requiring typing-extensions on Python < 3.13 to only < 3.11, which will break installations on Python 3.11 and 3.12.

Confidence Score: 1/5

  • Not safe to merge - contains a critical bug that breaks Python 3.11 and 3.12 compatibility
  • While this PR correctly addresses the issue of packages with impossible future timestamps, it introduces a critical regression in the exceptiongroup package dependency marker that will prevent typing-extensions from being installed on Python 3.11 and 3.12, causing import failures. The project's pyproject.toml requires Python >=3.10, making this a blocking issue for the two most commonly used Python versions in production.
  • uv.lock - exceptiongroup typing-extensions marker is incorrectly restricted to Python < 3.11

Important Files Changed

File Analysis

Filename Score Overview
uv.lock 4/5 Downgrades multiple packages from versions with future upload dates (2026) to correctly dated versions, removes mediapy dependency from playground, changes platform markers

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant UV as UV Lock File
    participant PyPI as PyPI Registry
    
    Note over Dev,PyPI: Previous State (PR #964)
    Dev->>UV: Add uv.lock with packages
    Note over UV: Contains packages with<br/>future upload dates (2026-01-08)
    
    Note over Dev,PyPI: Current PR (#965)
    Dev->>UV: Downgrade packages to correct versions
    UV->>UV: bitsandbytes 0.49.1 → 0.49.0
    UV->>UV: build 1.4.0 → 1.3.0
    UV->>UV: playground 0.1.0 → 0.0.5
    UV->>UV: Remove mediapy, warp-lang dependencies
    UV->>UV: Add platform markers (exclude win32)
    UV->>UV: Update exceptiongroup marker
    Note over UV: Uses packages with<br/>valid historical dates (2025)
    
    UV-->>PyPI: Validates against registry
    PyPI-->>Dev: Packages available
Loading

source = { registry = "https://pypi.org/simple" }
dependencies = [
{ name = "typing-extensions", marker = "python_full_version < '3.13'" },
{ name = "typing-extensions", marker = "python_full_version < '3.11'" },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P0] The typing-extensions marker was changed from python_full_version < '3.13' to < '3.11', which will prevent typing-extensions from being installed on Python 3.11 and 3.12. This breaks exceptiongroup on those Python versions since it requires typing-extensions.

@paul-nechifor paul-nechifor deleted the actually-fix-uv-lock branch January 13, 2026 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant