fix: update querySelector to use decodeURIComponent for link hash#1
Merged
thetutlage merged 2 commits intodimerapp:developfrom Sep 3, 2024
Merged
fix: update querySelector to use decodeURIComponent for link hash#1thetutlage merged 2 commits intodimerapp:developfrom
thetutlage merged 2 commits intodimerapp:developfrom
Conversation
7nohe
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
If the hash link contains a non-English character string, the following error occurs.
Reproduction
Repository: https://github.com/7nohe/adonisjs-v6-docs-ja
Website: https://adonisjs-docs-ja.vercel.app
Solution
Decode the hash link before passing it to
querySelector.