Skip to content

Update to Bevy 0.9#272

Merged
sebcrozet merged 9 commits intodimforge:masterfrom
tim-blackbird:bevy-0.9
Nov 18, 2022
Merged

Update to Bevy 0.9#272
sebcrozet merged 9 commits intodimforge:masterfrom
tim-blackbird:bevy-0.9

Conversation

@tim-blackbird
Copy link
Contributor

@tim-blackbird tim-blackbird commented Nov 12, 2022

Blocked on a new release of nalgebra for the convert-glam022 feature.

bevy_reflect's handling of enums was changed, which now (correctly, I think) causes the Reflect derive for AsyncCollider to fail because it contains an item that is not Reflect.

99% of the changes this time is an update to entity spawning API.

Resolves #269

@msvbg
Copy link

msvbg commented Nov 13, 2022

May want to use dtolnay/rust-toolchain in CI to fix the let ... else error. It should use the latest stable Rust toolchain. (Like Bevy itself: bevyengine/bevy#6432)

@GuillaumeGomez
Copy link
Contributor

I opened #275 to help with this Rust CI version issue.

@tv42
Copy link

tv42 commented Nov 13, 2022

I'm sure you're aware, but the nalgebra release happened.

This PR builds & works after a small patch:

diff --git i/bevy_rapier2d/Cargo.toml w/bevy_rapier2d/Cargo.toml
index bc10eb5..0b321b2 100644
--- i/bevy_rapier2d/Cargo.toml
+++ w/bevy_rapier2d/Cargo.toml
@@ -30,7 +30,7 @@ enhanced-determinism = [ "rapier2d/enhanced-determinism" ]

 [dependencies]
 bevy = { version = "0.9.0-dev", default-features = false, features = ["bevy_asset", "bevy_scene"] }
-nalgebra = { version = "^0.31.1", features = [ "convert-glam021" ] }
+nalgebra = { version = "^0.31.4", features = [ "convert-glam022" ] }
 # Don't enable the default features because we don't need the ColliderSet/RigidBodySet
 rapier2d = "0.16.0"
 bitflags = "1"
@@ -42,7 +42,7 @@ serde = { version = "1", features = [ "derive" ], optional = true}
 bevy = { version = "0.9.0-dev", default-features = false, features = ["x11"]}
 oorandom = "11"
 approx = "0.5.1"
-glam = { version = "0.21", features = [ "approx" ] }
+glam = { version = "0.22", features = [ "approx" ] }

 [package.metadata.docs.rs]
 # Enable all the features when building the docs on docs.rs

@tim-blackbird
Copy link
Contributor Author

This PR already includes those changes.

@sebcrozet sebcrozet mentioned this pull request Nov 14, 2022
@GuillaumeGomez
Copy link
Contributor

#275 was merged so rebase on it and let's see what the CI says? :)

@webbertakken
Copy link

I can confirm this works.

@Waridley
Copy link

I can confirm this works.

Same

@stillonearth
Copy link

Didn't work for me unless I set nalgebra version to 0.31.4 in my project's Cargo.toml directly.

@bugQ
Copy link

bugQ commented Nov 17, 2022

Didn't work for me unless I set nalgebra version to 0.31.4 in my project's Cargo.toml directly.

I had a similar issue until I noticed that my bevy dependency was still set to 0.8.1. Make sure it's set to 0.9.0.

I can confirm this works.

Same

Thirded. Is there anything else that needs to be done for a new crate release?

@sebcrozet sebcrozet merged commit 6ec76ca into dimforge:master Nov 18, 2022
@sebcrozet
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants