Skip to content

Replace quickcheck by proptest#837

Merged
sebcrozet merged 18 commits into
devfrom
proptest
Mar 1, 2021
Merged

Replace quickcheck by proptest#837
sebcrozet merged 18 commits into
devfrom
proptest

Conversation

@sebcrozet
Copy link
Copy Markdown
Member

@sebcrozet sebcrozet commented Feb 28, 2021

This PR replaces all our tests based on quickcheck with tests based on proptest.
With its version 1.0, quickcheck has the following issue:

These two issues makes quickcheck basically unusable by nalgebra

Proptest on the over hands allows us to specify the kind of values we want to test with very easily. @Andlon already did a significant amount of work to use proptest with nalgebra because proptest is already used in nalgebra-sparse. So even if quickcheck didn't have the two aforementioned issues, it would make sense to switch to proptest anyway.

@sebcrozet
Copy link
Copy Markdown
Member Author

sebcrozet commented Mar 1, 2021

For some reasons, CircleCI is now failing lots of tests randomly. This appears to be caused by not having enough memory.
So I'm switching to GitHub Actions instead which does not have this problem.

@sebcrozet sebcrozet merged commit b97a3d0 into dev Mar 1, 2021
@sebcrozet sebcrozet deleted the proptest branch March 1, 2021 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant